Author Topic: [Source] email.py  (Read 933 times)

0 Members and 1 Guest are viewing this topic.

Offline daxda

  • Peasant
  • *
  • Posts: 114
  • Cookies: 112
  • Not the guy you're looking for
    • View Profile
    • Daxda on Github
[Source] email.py
« on: October 28, 2013, 12:34:25 pm »
I've recently just finished my first little cli mail client, it walks you through the process of writing an email.
As always, feedback, improvements and critique are welcome, use it how you like and create your own stuff based on it.

[gist]Daxda/7195314[/gist]
« Last Edit: April 23, 2014, 08:25:55 pm by daxda »

Offline proxx

  • Avatarception
  • Global Moderator
  • Titan
  • *
  • Posts: 2803
  • Cookies: 256
  • ФФФ
    • View Profile
Re: [Source] email.py
« Reply #1 on: October 28, 2013, 01:06:16 pm »
Looks nice.
Printing statements from a class might be considered strange in certain cases.
If I was to use this from another program I wouldnt want it to be interactive.
In that case it might be better to actually do the config from a parameter perspective, at least that is what I would do.
For example; Mail.config(PROVIDER=default,PASSWORD,USERNAME,TYPE=default)

Again this is personal but I would use the class as a template and the 'data feeding' seperate.
Or maybe Im just plain wrong, anyone with more insight ?

Wtf where you thinking with that signature? - Phage.
This was another little experiment *evillaughter - Proxx.
Evilception... - Phage