Ordering Numbers into Ascending Order

[Drahgon]

Hey, so a few posts ago I showed some code regarding ordering numbers into ascending order. I discovered the bubble-sort algorithm and after being sent this code by a user on this forum, decided to see if it worked. However it doesn't output anything.

I have absolutely no idea why as the for loop at the bottom should output all the numbers ... but for some reason it doesn't (or at least 1 number).



This should work .. the first loop checks the value of the first number against the value of the second and then the third etc.
The outer for loop counter then makes it reset the j counter inside and so starts all over again. There are 100 checks on the various numbers in the array 's'.

Then at the end the for loop will simply print out the array 's' based on the value of 'i' at each of the loop counts. I fail to see what is actually going wrong here.

This is the console window:



As you can see, the array seems to get stored and potentially sorted.. but then the program just ends.

Any help would be great

[Kurajber]

Hello again.

Glad to see your progress.

Your problem is in your for loops, you don't declare starting value for i. After the first loop, i has a value of 10, so other two loops don't even start.

[kenjoe41]

In all yoooour looooops, you never declare a starting value for you palceholders come on, really? Get to work boy.

And next time, don't use images, post the code here, i care less now above your BBcode coloring but do post it.

[Drahgon]

Hello again.

Glad to see your progress.

Your problem is in your for loops, you don't declare starting value for i. After the first loop, i has a value of 10, so other two loops don't even start.

Thanks, its been going well(ish). I see ok .. but I declare that starts from 0 at the top ? Do I have to purely declare it's value locally?

[Drahgon]

In all yoooour looooops, you never declare a starting value for you palceholders come on, really? Get to work boy.

And next time, don't use images, post the code here, i care less now above your BBcode coloring but do post it.

As I said to the post above, I declared the value within main's scope. Not sure why i have to declare it locally.

[spaceman]

Before first loop you set i to 0 ok but sice first for loop i changed from 0 to 9. So if you want use i again in other loops as counter set it back to 0. Or use diferent counter.

[Kurajber]

Thanks, its been going well(ish). I see ok .. but I declare that starts from 0 at the top ? Do I have to purely declare it's value locally?

Basically, the for loops work by increasing the given value while given condition is true. So, your condition being i<10, when i reaches 10, the loop stops. So, as I said, after the first loop, that is the value of i.

Most commonly, the initial value is declared when you call the loop, eg.

Code: [Select]

for(x=1; x<=10; x++)Take a look at this: http://www.tutorialspoint.com/cplusplus/cpp_for_loop.htm

I still feel that you're getting ahead of yourself, I suggest you again to try to actually understand how basic stuff works before trying to do stuff.

[Drahgon]

Basically, the for loops work by increasing the given value while given condition is true. So, your condition being i<10, when i reaches 10, the loop stops. So, as I said, after the first loop, that is the value of i.

Most commonly, the initial value is declared when you call the loop, eg.

Code: [Select]

for(x=1; x<=10; x++)Take a look at this: http://www.tutorialspoint.com/cplusplus/cpp_for_loop.htm

I still feel that you're getting ahead of yourself, I suggest you again to try to actually understand how basic stuff works before trying to do stuff.

So I finally got it to work ! Thanks for all the help